[PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can

Christoph Hellwig hch at lst.de
Wed Aug 3 02:04:06 PDT 2016


On Tue, Aug 02, 2016 at 10:53:39AM +0300, Sagi Grimberg wrote:
> Relying on ctrl state in nvme_rdma_shutdown_ctrl is wrong because
> it will never be NVME_CTRL_LIVE (delete_ctrl or reset_ctrl invoked it).
> 
> Instead, check that the admin queue is connected. Note that it is safe
> because we can never see a copmeting thread trying to destroy the admin
> queue (reset or delete controller).
> 
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list