[PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces
Sagi Grimberg
sagi at grimberg.me
Mon Aug 1 04:21:17 PDT 2016
>> - nvme_remove_namespaces(&ctrl->ctrl);
>> - nvme_rdma_shutdown_ctrl(ctrl);
>> nvme_uninit_ctrl(&ctrl->ctrl);
>> + nvme_rdma_shutdown_ctrl(ctrl);
>
> How safe is the reordering here? The description should explain why
> it's fine.
The reordering is safe because we do want everything in uninit_ctrl
(flush aen,scan and ns-remove) to happen before we shutdown the rdma
stuff. I'll add to the change log.
Thanks!
More information about the Linux-nvme
mailing list