[PATCH 2/5] nvme: introduce a controller state machine

Sagi Grimberg sagi at grimberg.me
Mon Apr 18 11:36:58 PDT 2016


> @@ -1893,7 +1888,10 @@ static void nvme_reset_work(struct work_struct *work)
>   		nvme_dev_add(dev);
>   	}
>
> -	clear_bit(NVME_CTRL_RESETTING, &dev->flags);
> +	if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_LIVE)) {
> +		dev_warn(dev->ctrl.device, "failed to mark controller live\n");
> +		goto out;
> +	}
>   	return;
>
>    out:

You're missing a state change before removing a
dead controller...



More information about the Linux-nvme mailing list