[PATCH] NVMe: Re-introduce polling for completions

Judy Brock-SSI judy.brock at ssi.samsung.com
Tue Apr 5 22:22:06 PDT 2016


> Maybe you want both?
I think that would be a good solution.

-----Original Message-----
From: Keith Busch [mailto:keith.busch at intel.com] 
Sent: Tuesday, April 05, 2016 3:30 PM
To: Judy Brock-SSI
Cc: Christoph Hellwig; Jens Axboe; linux-nvme at lists.infradead.org
Subject: Re: [PATCH] NVMe: Re-introduce polling for completions

On Tue, Apr 05, 2016 at 10:04:22PM +0000, Judy Brock-SSI wrote:
> Going straight to MSI-x is a higher risk change since re-introducing polling restores code that was in place previously with no reported problems whereas changing the init path to something new has no test time on it.

Well, I wouldn't say "no" test time since we have a well tested path that goes straight to MSI-x in place for some time.

If we rely on polled completions during initialization, we potentially add up to 2 seconds for device initialization to complete (1 second polling interval * 2 commands using broken IRQ).

Maybe you want both?



More information about the Linux-nvme mailing list