[PATCH] nvme: Add error checking in nvme_create_io_queues

Keith Busch keith.busch at intel.com
Mon Sep 28 06:50:23 PDT 2015


On Sat, 26 Sep 2015, Christoph Hellwig wrote:
> Keith, do you remember why nvme_remove_disks is called through a
> workqueue?  I'd much rather do the work in line and in the proper place,
> queues should never leave nvme_create_io_queues half-setup, and
> namespaces should probably be removed by nvme_dev_start if we don't
> have any working I/O queues after a resume or reset.

A resume from S3/S4 will deadlock if we try to delete inaccessible
disks from the resume context, so using the work queue instead. There
is probably a better way to do this now that we probe asynchronously,
we can resume the same way.



More information about the Linux-nvme mailing list