[PATCH] nvme: Add error checking in nvme_create_io_queues

Jon Derrick jonathan.derrick at intel.com
Thu Sep 24 12:41:33 PDT 2015


On Thu, Sep 24, 2015 at 07:23:27PM +0000, Keith Busch wrote:
> On Thu, 24 Sep 2015, Jon Derrick wrote:
> >allow nvme_create_io_queues to return an error if the first io queue
> >fails to be allocated or initialized
> 
> If the driver gets far enough to attempt creating IO queues, the device
> can be managed so I don't think we want to error out and bail on the
> device in this scenario, even though it is not IO capable.
> 

Very good point.

I think just the dev_warn should suffice then, without the teardown.
After testing I have not seeing any issues with only leaving the controller handle up.

> >Signed-off-by: Jon Derrick <jonathan.derrick at intel.com>
> >---
> >drivers/block/nvme-core.c | 20 ++++++++++++++++----
> >1 file changed, 16 insertions(+), 4 deletions(-)



More information about the Linux-nvme mailing list