[PATCH 3/4] block: Refuse adding appending a gaped integrity page to a bio

Sagi Grimberg sagig at dev.mellanox.co.il
Sun Sep 13 00:53:01 PDT 2015


On 9/11/2015 1:22 AM, Martin K. Petersen wrote:
>>>>>> "Sagi" == Sagi Grimberg <sagig at dev.mellanox.co.il> writes:
>
>>> For some workloads I think bouncing is inevitable by virtue of the PI
>>> payload being teeny tiny by design.
>
> Sagi> I see. I guess we can bounce DIX data, but is it always "right" to
> Sagi> bounce? I don't know, as you say, it is workload dependent.
>
> The right place to make that call, I guess, is in
> bio_integrity_add_page() based on whether we exceed any of the
> constraints set by the LLD.

In case the consumer passed a gappy integrity payload then we can bounce 
but AFAICT, merge flows do not include a call site to
bio_integrity_add_page.

It would be easy enough to bounce gappy IOs and refuse gappy merges,
would that be sufficient?

Sagi.



More information about the Linux-nvme mailing list