[PATCH] NVMe: Set affinity after allocating request queues

Keith Busch keith.busch at intel.com
Fri Sep 4 08:12:29 PDT 2015


On Fri, 4 Sep 2015, 김경산 wrote:
> Hello, Keith Busch.
> Thank you for the patch. I've confirmed  that setting hint is now working with the patch.
>
> However, I think setting affinity hint is not sufficient to balance interrupts.
> We've observed that affinity hint has not much impact on distributing interrupts across cores on  a distro such as debian 7.0
> while setting affinity directly has worked on the distro.
>
> Plus, hint information is also provided by device driver with intention that balances interrupt loads across cores.
> And it also needs to collaborate with irqbalance option to work on.
> So, I think setting affinity is a clear way to achieve balancing effect provided by driver rather than hint information.
> I hope to listen your opinion regarding this.

No argument from me against having an API to directly set the irq
affinity. I think it's a great idea.

This patch just puts the hint where it ought to be. My machines have a
different patch that create a request_queue without a namespace (for
hidden access), so I didn't notice the async scanning broke the hint
on mainline.

With this patch, and when the new irq affinity set function is
exported (assuming that is being done), you can just change the
irq_set_affinity_hint() to the new function.


More information about the Linux-nvme mailing list