[PATCH] NVMe:Expose model attribute in sysfs

Keith Busch keith.busch at intel.com
Tue Sep 1 10:25:48 PDT 2015


On Tue, 1 Sep 2015, Sujith Pandel wrote:
> On Tue, Aug 25, 2015 at 12:14:39PM -0500, Keith Busch wrote:
>> But if we're going to have more than one sysfs entry, we can manage
>> this easier using attribute groups instead. There are lots of examples
>> in the kernel for this, like scsi_sysfs.c or blk-mq-sysfs.c
>
> Since there are only two sysfs attributes here as of now,
> I will be going with your former suggestion of using a new goto label.

Aww, that just forces the person who finds a need to add a third entry
to implement a better design, or maybe he/she will use the same reasoning
to shift that problem to the next person.

The "zero, one, infinity rule" puts 2 in the same catagory as infinity.



More information about the Linux-nvme mailing list