[PATCH v13 2/5] gennvm: Generic NVM manager

Jens Axboe axboe at kernel.dk
Thu Oct 29 00:34:55 PDT 2015


On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
> On 10/28/2015 08:30 AM, Matias Bjørling wrote:
>> The implementation for Open-Channel SSDs is divided into media
> [...]
>> +        lun->reserved_blocks = 2; /* for GC only */
>> +        lun->vlun.id = i;
>> +        lun->vlun.lun_id = i % dev->luns_per_chnl;
>> +        lun->vlun.chnl_id = i / dev->luns_per_chnl;
>
> Please use do_div(). % would be not supported in some platforms, as
> the kbuild pointed in V12.

Neither of those are 64-bit variables, which is where you end up with 
the problem on 32-bit archs.

-- 
Jens Axboe




More information about the Linux-nvme mailing list