[PATCH 8/9] nvme: remove dead controllers from a work item

Christoph Hellwig hch at lst.de
Thu Oct 22 11:12:40 PDT 2015


On Thu, Oct 22, 2015 at 06:10:15PM +0000, Busch, Keith wrote:
> On Thu, Oct 22, 2015 at 02:03:40PM +0200, Christoph Hellwig wrote:
> > Compared to the kthread this gives us multiple call prevention for free.
> 
> My apologies in advance, I usually try to be more helpful debugging
> new issues, but I'm running low on time today. I might be able to dig
> into this more tomorrow, but if you could, please verify what happens
> if an admin command times out during initialization. The reset_work
> gets queued twice on two different work_queues and causes trouble. I
> get one of several crashes or warnings after applying the whole series,
> but this is the most frequent I'm seeing so far:

Oops - I'm queing it both on the system workqueue and nvme_workq, which
is clearly broken.  I'll fix it in the next resend.



More information about the Linux-nvme mailing list