[PATCH 06/18] nvme: split a new struct nvme_ctrl out of struct nvme_dev

Sagi Grimberg sagig at dev.mellanox.co.il
Wed Oct 21 07:40:42 PDT 2015


On 10/20/2015 2:30 PM, Christoph Hellwig wrote:
> On Tue, Oct 20, 2015 at 01:44:01PM +0300, Sagi Grimberg wrote:
>> I wasn't suggesting moving it to nvme_ctrl, I was suggesting to keep it
>> in nvme_dev and maybe add a helper have nvme_ctrl_to_dev(ctrl)->dev used
>> in slow paths. It would allow to remove the copy pointer in nvme_ctrl.
>
> But it would require adding a function pointer to get the location from
> the different transport drivers.  A pointer seems much simpler than that.
>

Yea, I'm fine with that...

Reviewed-by: Sagi Grimberg <sagig at mellanox.com>



More information about the Linux-nvme mailing list