[PATCH 06/18] nvme: split a new struct nvme_ctrl out of struct nvme_dev

Christoph Hellwig hch at lst.de
Tue Oct 20 03:26:17 PDT 2015

On Tue, Oct 20, 2015 at 01:19:45PM +0300, Sagi Grimberg wrote:
> Can you explain why nvme_ctrl needs an additional struct device pointer?
> (I understand it will go away from your statement "at the moment"
> haven't read the rest of the patch set yet).

No, it won't go away for the foreseeable future.  I don't want to move
any members used in the hot path to sturct nvme_ctrl so that drivers can
be optimized in this path without impacting the generic code.  Both for
PCIe and Fabrics we need to squeeze the last bit of performance out and
I don't want to have to cacheline optimize nvme_ctrl or even worse
interactions between it and the containing structures.

More information about the Linux-nvme mailing list