On Thu, Oct 15, 2015 at 11:14:14PM -0700, Ming Lin wrote: > Should nvme_core_{init,exit} be called in core.c? We can't do that until core.c is built into a separate module. Your patch will only work when NVMe is built into the kernel. I want to defer the split until it can actually be used in tree.