[PATCH] NVMe: Fix memory leak on retried commands

Jens Axboe axboe at fb.com
Thu Oct 15 12:40:46 PDT 2015

On 10/15/2015 01:34 PM, Keith Busch wrote:
> On Tue, 13 Oct 2015, Keith Busch wrote:
>> Resources are reallocated for requeued commands, so unmap and release
>> the iod for the failed command.
> Hi Jens,
> Since you're applying changes for 4.3, can you add this one? It's a
> pretty bad memory leak and causes a kernel hang if you remove a drive
> because of a busy dma pool. You'll get messages spewing like this:
>    nvme 0000:xx:xx.x: dma_pool_destroy prp list 256, ffff880420dec000 busy
> and lock up pci and the driver since removal never completes while
> holding a lock.

Yeah, it's applied. It's hand applied since it no longer applied after 
the error fixup from Christoph:


> I think this should go into stable back to 4.0. I'm not entirely sure how
> to do that. Will the Cc on the original achieve that when this is merged?

I think your patch is fine, it's marked stable and with 4.0 and up. So 
should be no need to do anything else.

Jens Axboe

More information about the Linux-nvme mailing list