[PATCH 2/5] block: Consolidate static integrity profile properties

Christoph Hellwig hch at infradead.org
Wed Oct 14 00:23:03 PDT 2015


On Tue, Oct 13, 2015 at 06:11:50PM -0700, Dan Williams wrote:
> >  int nd_integrity_init(struct gendisk *disk, unsigned long meta_size)
> >  {
> > -       struct blk_integrity integrity = {
> > +       struct blk_integrity bi;
> > +       struct blk_integrity_profile profile = {
> >                 .name = "ND-PI-NOP",
> >                 .generate_fn = nd_pi_nop_generate_verify,
> >                 .verify_fn = nd_pi_nop_generate_verify,
> > -               .tuple_size = meta_size,
> > -               .tag_size = meta_size,
> 
> 'profile' here needs to be made static since we reference rather than
> copy the profile data at blk_integrity_register() time.  This is part
> of, but I don't think all of, my blk_integrity shutdown woes.

Oh, yes.  Can we also add a single noop profile to block/blk-integrity.c
while we're at it?




More information about the Linux-nvme mailing list