[PATCH 3/3] nvme: refactor nvme_queue_rq

Christoph Hellwig hch at lst.de
Fri Oct 9 23:53:19 PDT 2015

On Fri, Oct 09, 2015 at 02:11:54PM -0600, Jon Derrick wrote:
> Hi Christoph,
> > +	if (!nvme_setup_prps(dev, iod, blk_rq_bytes(req)))
> > +	    	goto out_unmap;
> Git am complains about whitespacing here.

Hmm, checkpatch was fine with it.  I know there was odd whitespacing on
the lines before I touched i but I though I fixed all that.

> The set looks fine to me. I'm tempted to do some performance testing with the microoptimizations present here. Have you seen any results yourself?

On the PCIe side I've only tested it with normal Flash devices where
I didn't see a difference, so numbers would be welcome.

More information about the Linux-nvme mailing list