[PATCHv2 2/2] NVMe: Simplify device resume on io queue failure

Christoph Hellwig hch at infradead.org
Fri Oct 2 09:57:26 PDT 2015


On Fri, Oct 02, 2015 at 10:37:29AM -0600, Keith Busch wrote:
> Releasing IO queues and disks was done in a work queue outside the
> controller resume context to delete namespaces if the controller failed
> after a resume from suspend. This is unnecessary since we can resume
> a device asynchronously.
> 
> This patch makes resume use probe_work so it can directly remove
> namespaces if the device is manageable but not IO capable. Since the
> deleting disks was the only reason we had the convoluted "reset_workfn",
> this patch removes that unnecessary indirection.
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list