[PATCH] NVMe: Shutdown fixes

Jens Axboe axboe at fb.com
Tue Nov 24 17:39:54 PST 2015


On 11/24/2015 04:30 PM, Keith Busch wrote:
> The controller must be disabled prior to completing a presumed lost
> command. This patch makes the shutdown safe to simultaneous invocations
> using mutex, and directly calls shutdown from the timeout handler if
> timeout occurs.
>
> The driver must directly set req->errors to get the appropriate status
> propogated to the caller, since the timeout handler already set the
> targeted request to "complete". The shutdown unconditionally clears
> all outstanding commands, so it is safe to return "EH_HANDLED" from the
> timeout handler and assume the command was completed.

Much better, looks good to me.

-- 
Jens Axboe




More information about the Linux-nvme mailing list