[PATCH] NVMe: Split shutdown work

Christoph Hellwig hch at infradead.org
Mon Nov 23 23:34:48 PST 2015


On Mon, Nov 23, 2015 at 11:17:45AM -0700, Keith Busch wrote:
> Setting the queue count has a special check for a disabled device in
> order to set an appropriate return code as this command may legitimately
> fail.

Btw, I've tried to understand this as the explanation didn't make sense
to me.  I think I finally found the culprit, and it's this text:

"This feature shall only be issued during initialization prior to creation
 of any I/O Submission and/or Completion Queues. The value allocated shall
 not change between resets."

To be this doesn't indicated that it can legitimately fail. but rather
that we must not even submit it during a reset or resume.  One more
reason for a proper state model..



More information about the Linux-nvme mailing list