[PATCH 1/1] nvme: temporary fix for Apple NVMe controller reset

Christoph Hellwig hch at infradead.org
Sat Nov 21 00:20:41 PST 2015


Hi Stephan,

> +	/*
> +	 * Temporary fix for the Apple controller found in the MacBook8,1 and
> +	 * some MacBook7,1 to avoid controller resets and data loss.
> +	 */
> +	if (pdev->vendor == PCI_VENDOR_ID_APPLE && pdev->device == 0x2001)
> +		dev->q_depth = 2;

Can you add a dev_warn() here?  A NVMe device with queue depth is going
to perform bady, and we should tell people that we're applying a crude
workaround.

Otherwise this looks fine to me to get you guys going, but I really hope
we'll find the root cause soon.



More information about the Linux-nvme mailing list