[PATCH 02/47] block: fix blk_abort_request for blk-mq drivers

Christoph Hellwig hch at lst.de
Fri Nov 20 23:34:10 PST 2015


On Fri, Nov 20, 2015 at 05:20:21PM -0500, Jeff Moyer wrote:
> > We only added the request to the request list for the !blk-mq case,
> > so we should only delete it in that case as well.
> 
> I think I'd rather see the conditional moved into blk_delete_timer.
> Breaking the balance of add/delete seems ugly to me.  I had expected to
> see a later patch make use of the list, but nothing does.  So, this is
> just a cleanup (as opposed to a preparatory patch), yes ?

It was needed in an earlier version of the series.  Note that it's still
needed e.g. for libsas.



More information about the Linux-nvme mailing list