[PATCH 8/8] nvme-loop: add a NVMe loopback device

Sagi Grimberg sagig at dev.mellanox.co.il
Mon Nov 16 01:35:34 PST 2015



On 16/11/2015 10:29, Christoph Hellwig wrote:
> On Sun, Nov 15, 2015 at 09:18:34PM +0200, Sagi Grimberg wrote:
>>
>>> +	ctrl->queue_count = 1; /* admin queue */;
>>> +	if (nr_io_queues > 0)
>>> +		ctrl->queue_count += nr_io_queues;
>>> +	else
>>> +		ctrl->queue_count += num_possible_cpus();
>>
>> This should really be num_online_cpus(), I get way more than
>> I need with num_possible_cpus()...
>
> Maybe.  But then we'd want a hot plug event.  The whole number of
> contexts thing is a bit of a mess.

Or we can just remain with more or less queues then cpus... it is
already possible if the user used nr_io_queues != num_online_cpus()...



More information about the Linux-nvme mailing list