[PATCH 07/12] nvme: special case AEN requests

Jens Axboe axboe at kernel.dk
Mon Nov 9 13:48:31 PST 2015


On 11/09/2015 02:43 PM, Keith Busch wrote:
> On Sat, Nov 07, 2015 at 09:45:01AM +0100, Christoph Hellwig wrote:
>> +		if (unlikely(nvmeq->qid == 0 &&
>> +				cqe.command_id < NVME_NR_AEN_COMMANDS)) {
>> +			nvme_finish_aen_cmd(nvmeq->dev, &cqe);
>> +			continue;
>
> As long as we're guaranteed the "reserved" tags are the lowest possible
> tag values, this'll work. But that seems more coincidence than by design.

That fact is just implementation detail, I don't think we should make 
assumptions about the range of reserved vs normal tags. That's just 
asking for trouble if this changes at some point.

-- 
Jens Axboe




More information about the Linux-nvme mailing list