Looks fine, Reviewed-by: Christoph Hellwig <hch at lst.de> ... but I doubt we'll ever bother updating it. Most architectures with arger page sizes also have iommus and would need different settings for different iommus vs direct mapping for very little gain. There's a reason why we never bothered for RDMA either.