[PATCH] NVMe: Avoid interrupt disable during queue init.
keith.busch at intel.com
Fri May 22 07:48:13 PDT 2015
On Thu, 21 May 2015, Parav Pandit wrote:
> On Fri, May 22, 2015 at 1:04 AM, Keith Busch <keith.busch at intel.com> wrote:
>> The q_lock is held to protect polling from reading inconsistent data.
> ah, yes. I can see the nvme_kthread can poll the CQ while its getting
> created through the nvme_resume().
> I think this opens up other issue.
> nvme_kthread() should,
> Instead of,
> struct nvme_queue *nvmeq = dev->queues[i];
> it should do,
> struct nvme_queue *nvmeq = rcu_dereference(dev->queues[i]);
The rcu protection on nvme queues was removed with the blk-mq conversion
as we rely on that layer for h/w access.
More information about the Linux-nvme