[PATCH] NVMe: Avoid interrupt disable during queue init.

Jens Axboe axboe at kernel.dk
Thu May 21 11:39:18 PDT 2015


On 05/21/2015 06:12 PM, Parav Pandit wrote:
> Avoid diabling interrupt and holding q_lock for the queue
> which is just getting initialized.
>
> With this change, online_queues is also incremented without
> lock during queue setup stage.
> if Power management nvme_suspend() kicks in during queue setup time,
> per nvmeq based q_lock spinlock cannot protect device wide
> online_queues variable anyway.

Seems fairly pointless, it's not like it's a hot path...

-- 
Jens Axboe




More information about the Linux-nvme mailing list