[PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c

Keith Busch keith.busch at intel.com
Wed May 13 10:12:10 PDT 2015

On Wed, 13 May 2015, Matthew Wilcox wrote:
> On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote:
>> This removes the include statement for including the header file,
>> linux/mm.h in the file, nvme-core.c due this driver file never
>> calling any functions from the header file, linux/mm.h  and
>> only adding bloat to this driver by including this unnessary
>> header file.
> Nick, I'm not going to apply this patch, simply because the effort of
> verifying that you haven't made a mistake is greater than the gain we
> might get from applying it.

The driver does use functions defined in linux/mm.h: get_user_pages_fast
is one of them. It compiles without including the header because another
we include includes mm.h, but we don't want to depend on that!

Don't worry, I didn't waste time checking; I just happened to know that
one off the top.

More information about the Linux-nvme mailing list