[PATCH 04/11] nvme: remove the unused dma_addr_t arguments to nvme_{get, set}_features

Matthew Wilcox willy at linux.intel.com
Fri May 8 12:03:51 PDT 2015


On Fri, May 08, 2015 at 06:00:29PM +0200, Christoph Hellwig wrote:
>  int nvme_get_features(struct nvme_dev *dev, unsigned fid, unsigned nsid,
> -					dma_addr_t dma_addr, u32 *result)
> +		u32 *result)
>  {
>  	struct nvme_command c;
>  
>  	memset(&c, 0, sizeof(c));
>  	c.features.opcode = nvme_admin_get_features;
>  	c.features.nsid = cpu_to_le32(nsid);
> -	c.features.prp1 = cpu_to_le64(dma_addr);
>  	c.features.fid = cpu_to_le32(fid);
>  
>  	return __nvme_submit_sync_cmd(dev->admin_q, &c, result, 0);

Wait, what?  The PRP1 field is used for LBA Range Type and Autonomous
Power State Transitions.




More information about the Linux-nvme mailing list