[PATCHv3] NVMe: write_long SCSI to NVMe translation implementation

Matthew Wilcox willy at linux.intel.com
Tue Mar 24 09:23:01 PDT 2015


On Mon, Mar 23, 2015 at 07:18:13PM +0530, Sunad Bhandary S wrote:
> +	case WRITE_LONG:
> +		retcode = nvme_trans_write_long(ns, hdr, cmd);
> +		break;
> +	case SERVICE_ACTION_OUT_16:
> +		if (IS_WRITE_LONG_16(cmd))
> +			retcode = nvme_trans_write_long(ns, hdr, cmd);
> +		else
> +			goto out;
> +		break;
>  	default:
>   out:

Umm, why not simply:

	case SERVICE_ACTION_OUT_16:
		if (IS_WRITE_LONG_16(cmd))
			retcode = nvme_trans_write_long(ns, hdr, cmd);
		break;




More information about the Linux-nvme mailing list