[PATCHv2] NVMe: Stripe queue IRQ vector assignments

Keith Busch keith.busch at intel.com
Wed Jun 10 17:22:27 PDT 2015


On Wed, 10 Jun 2015, Christoph Hellwig wrote:
> On Wed, Jun 10, 2015 at 10:41:30AM -0600, Jon Derrick wrote:
>> a) There is a known issue in one controller where irq coalescing cannot
>> occur on vectors to which the admin queue is assigned. This patch assigns
>> the admin queue its own vector, as long as there are enough vectors
>> available to assign one to each io queue and the admin queue.
>
> I think this should be a quirk for that particular PCI ID, and needs
> a comment int the code explaining the reason.

Let's just remove this from the commit message. The real win is the second
part, which we know to be a worthwhile gain in senarios where h/w queues
and cpus exceed available irq's. This other coalescing benefit is a nice
bonus, but not necessary to consider for this commit.



More information about the Linux-nvme mailing list