[PATCHv4 2/2] NVMe: Use CMB for the IO SQes if available

Jon Derrick jonathan.derrick at intel.com
Fri Jul 17 08:46:32 PDT 2015


> > +static int use_cmb_sqes = 1;
> > +module_param(use_cmb_sqes, int, 0644);
> > +MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes");
> 
> This should be a bool.
> 

> > +	}
> > +}
> 
> Can you just return an error on allocation failure here insead of
> checking sq_cmds after the call to the function?

Will do. Thanks!



More information about the Linux-nvme mailing list