[PATCH] NVMe: Reread partitions on metadata formats

Jens Axboe axboe at fb.com
Wed Jul 15 14:36:17 PDT 2015


On 07/14/2015 09:48 PM, Dan Williams wrote:
> On Tue, Jul 14, 2015 at 11:49 AM, Jens Axboe <axboe at fb.com> wrote:
>> On 07/14/2015 11:57 AM, Keith Busch wrote:
>>>
>>> This patch has the driver automatically reread partitions if a namespace
>>> has a separate metadata format. Previously revalidating a disk was
>>> sufficient to get the correct capacity set on such formatted drives,
>>> but partitions that may exist would not have been surfaced.
>>
>>
>> Looks sane to me. Paul, does this fix your issue?
>
> NVDIMM namespaces with metadata space will run into this same problem.
> Why not make revalidate_disk re-read partitions?

Yeah that's a good point, we should try that. I'll queue up Keith's fix 
for now since it's fixing a real bug, then we can revisit and kill it later.

-- 
Jens Axboe




More information about the Linux-nvme mailing list