[PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes

Jens Axboe axboe at fb.com
Wed Jan 7 08:22:38 PST 2015


On 01/06/2015 07:57 PM, Keith Busch wrote:
> Second try, this time tested against many more scenarios than before
> with error injection and surprise hot-removal and intermittent resets.
>
> I'm adding a lot of stuff outside the driver, but I didn't find a
> cleaner way to a lot of these things. This makes me a little nervous,
> so please let me know if anything seems amiss here. I don't think any
> of the blk-mq changes could possibly be harmful to anyone else since
> nvme is the only driver that uses most of the additions.
>
> The only issue remaining I found is unfreezing queues might tigger the
> percpu_ref_reinit WARN_ON_ONCE when the driver restarts a request_queue
> with queued up IO's.
>
> This is against linux-block/for-next.

Series looks sane to me, apart from the timeout change I replied to 
separately. Could you turn that into a request flag and respin the 
series on top of that?

> Jens,
> I believe fourth one ("abort requeue list") is from you, but I didn't find
> the patch.

Yeah it is, sent to you on 12/23 as part of the "nvme-blkmq fixes" thread.

-- 
Jens Axboe




More information about the Linux-nvme mailing list