[PATCH 3/5] NVMe: Remove queue freezing on resets

Sagi Grimberg sagig at dev.mellanox.co.il
Thu Dec 31 09:19:37 PST 2015


>> NVMe submits all commands through the block layer now. This means we
>> can let requests queue at the blk-mq hardware context since there is no
>> path that bypasses this anymore. This means we don't need to freeze the
>> queues anymore and simply stop the h/w queues from running during a
>> reset.
>
> Does this have any dependencies? I tried this at some point but it
> didn't work as I expected it to.

OK, I figured out what I did wrong.


>> This also fixes a WARN in percpu_ref_reinit when the queue was unfrozen
>> with requeued requests.
>
> Oh yes, I've seen this one too! I'll test it for sure.

This works great for me,

Tested-by: Sagi Grimberg <sagig at mellanox.com>



More information about the Linux-nvme mailing list