[PATCH v2] nvme: temporary fix for Apple controller reset

Jens Axboe axboe at kernel.dk
Tue Dec 1 11:56:47 PST 2015


On 12/01/2015 12:46 PM, Stephan Günther wrote:
> The patch below has been reviewed by Christoph and reported to work.
> However, there is still no sign that it will be applied to linux-4.4.
>
> Please either undo commit c74dc7801d515d01847fd5cf2b472489fa5717b1,
> which added the PCI ID of the Apple controller, or merge the patch below
> asap.
>
>
> Currently, the driver will make that controller destroy data!

Honestly, I'd rather revert the pci id addition, unless there's 
conclusive evidence that limiting the (per queue) depth to 2 really does 
fix the issue. Is this what the OSX driver does? What testing was done 
to ascertain that 2 is the magic number? Does it just make it harder to 
hit, or does it really fix it?


-- 
Jens Axboe




More information about the Linux-nvme mailing list