[PATCHv4] blk: Replace SG_GAPGS with new queue limits mask

Christoph Hellwig hch at infradead.org
Thu Aug 6 23:34:15 PDT 2015


On Thu, Aug 06, 2015 at 08:36:58PM +0300, Sagi Grimberg wrote:
> >+	if (!queue_virt_boundary(q))
> >+		return false;
> >+	return offset ||
> >+		((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
> 
> I'm wandering if it deserves an unlikely() statement given it really
> depends on the application workload...

I'd prefer to not micro-optimize using unlikely unless we have a really
good reason for it.



More information about the Linux-nvme mailing list