[PATCH] NVMe: Update SCSI Inquiry VPD 83 translation

Matthew Wilcox willy at linux.intel.com
Tue Dec 2 12:50:15 PST 2014


On Tue, Dec 02, 2014 at 12:56:16PM -0700, Keith Busch wrote:
> +	if (readl(&dev->bar->vs) >= 0x10100) {

I think we want an NVME_VERSION() macro that maybe looks something like this:

#define NVME_VERSION(major, minor) (((major) << 16) | ((minor) << 8))

Then you can make this:

	if (readl(&dev->bar->vs) >= NVME_VERSION(1, 1))

What do you think?




More information about the Linux-nvme mailing list