[PATCH] NVMe: Add discard support for capable devices

Matthew Wilcox willy at linux.intel.com
Tue Nov 6 11:15:09 EST 2012


On Tue, Nov 06, 2012 at 11:10:08AM -0500, Matthew Wilcox wrote:
> Although ... now I'm looking at the failure path in
> nvme_submit_bio_queue(), isn't it the case that we'll leak cmdids if
> nvme_map_bio() fails?  And in this case?  So I think we also need:
> 
> + free_cmdid:
> +	free_cmdid(nvmeq, cmdid, NULL);
>   free_iod:	
> 
> And then change the 'goto free_iod' to 'goto free_cmdid'.

Never mind; just got to the patch where you fixed this :-)



More information about the Linux-nvme mailing list