[PATCH 3/3] mtd: block2mtd: convert _block2mtd_erase() to folios
Tal Zussman
tz2294 at columbia.edu
Thu Oct 15 08:19:23 PDT 2026
On 10/15/26 5:14 AM, Miquel Raynal wrote:
> Hi Tal,
>
> On 15/10/2026 at 03:45:56 GMT, sashiko-bot at kernel.org wrote:
>
>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> - [Medium] mm: missing folio->mapping re-validation after folio_lock()
>
> TBH, I don't know the folio API so I'll let you determine whether this
> is a real issue or not.
>
> Miquèl
>
It seems like it's a real but very rare pre-existing issue. It would require
invalidate_mapping_pages() to be called between the read_mapping_folio() and
folio_lock(), which isn't something that should happen here on any normal
workload. In any case, the fix is to check the mapping and retry if the
check fails. I'll add a patch at the start of the series fixing this for
erase and write.
Thanks,
Tal
More information about the linux-mtd
mailing list