[PATCH 5/7] spi: spi-qpic-snand: use the common qcom_nandc_set_read_loc_first() function
Gabor Juhos
j4g8y7 at gmail.com
Mon Nov 9 11:41:06 PST 2026
The common function from the 'qpic_common' module provides the same
functionality as the locally implemented counterpart.
Use the common function and remove the local one in order to reduce
code duplication.
No functional changes intended.
Signed-off-by: Gabor Juhos <j4g8y7 at gmail.com>
---
drivers/spi/spi-qpic-snand.c | 27 ++++-----------------------
1 file changed, 4 insertions(+), 23 deletions(-)
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
index 6774a0a5db2a..ad91edd5f6df 100644
--- a/drivers/spi/spi-qpic-snand.c
+++ b/drivers/spi/spi-qpic-snand.c
@@ -122,27 +122,6 @@ struct qpic_spi_nand {
bool quad_mode;
};
-static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc,
- int reg, int cw_offset, int read_size,
- int is_last_read_loc)
-{
- __le32 locreg_val;
- u32 val = FIELD_PREP(READ_LOCATION_OFFSET_MASK, cw_offset) |
- FIELD_PREP(READ_LOCATION_SIZE_MASK, read_size) |
- FIELD_PREP(READ_LOCATION_LAST_MASK, is_last_read_loc);
-
- locreg_val = cpu_to_le32(val);
-
- if (reg == NAND_READ_LOCATION_0)
- snandc->regs->read_location0 = locreg_val;
- else if (reg == NAND_READ_LOCATION_1)
- snandc->regs->read_location1 = locreg_val;
- else if (reg == NAND_READ_LOCATION_2)
- snandc->regs->read_location2 = locreg_val;
- else if (reg == NAND_READ_LOCATION_3)
- snandc->regs->read_location3 = locreg_val;
-}
-
static void qcom_spi_set_read_loc_last(struct qcom_nand_controller *snandc,
int reg, int cw_offset, int read_size,
int is_last_read_loc)
@@ -514,8 +493,10 @@ static void qcom_spi_set_read_loc(struct qcom_nand_controller *snandc, int cw, i
return qcom_spi_set_read_loc_last(snandc, reg_base, cw_offset,
read_size, is_last_read_loc);
else
- return qcom_spi_set_read_loc_first(snandc, reg_base, cw_offset,
- read_size, is_last_read_loc);
+ return qcom_nandc_set_read_loc_first(snandc, reg_base,
+ cw_offset,
+ read_size,
+ is_last_read_loc);
}
static void
--
2.56.0
More information about the linux-mtd
mailing list