[PATCH v5 13/28] mtd: spi-nor: swp: Create a TB intermediate variable

Tudor Ambarus tudor.ambarus at linaro.org
Fri May 22 09:19:19 PDT 2026



On 5/22/26 7:06 PM, Miquel Raynal wrote:
> 
> On 22/05/2026 at 12:39:48 +03, Tudor Ambarus <tudor.ambarus at linaro.org> wrote:
> 
>> On 5/7/26 7:46 PM, Miquel Raynal wrote:
>>> Ease the future reuse of the tb (Top/Bottom) boolean by creating an
>>> intermediate variable.
>>
>> Please squash this in the patch that needs it.
> 
> The problem with CMP addition is that it touches all functions all over
> the place. I want people to be able to focus on the CMP addition, not
> all the side changes which have nothing to do with the CMP addition by
> itself. Most of the preparation patches are just steps in that
> direction, they could also be squashed, but overall they make the final
> diff much simpler. I believe every small change making that last step a
> little bit easier to read goes into the right direction?

I was looking where was this particular bool used and couldn't find it.
Fine by me to keep as dedicated patch if you think a 3 line change
distracts the reader of the bigger scope.



More information about the linux-mtd mailing list