[PATCH v5 13/28] mtd: spi-nor: swp: Create a TB intermediate variable

Tudor Ambarus tudor.ambarus at linaro.org
Fri May 22 02:39:48 PDT 2026



On 5/7/26 7:46 PM, Miquel Raynal wrote:
> Ease the future reuse of the tb (Top/Bottom) boolean by creating an
> intermediate variable.

Please squash this in the patch that needs it.

> 
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
>  drivers/mtd/spi-nor/swp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c
> index 07269e09370a..540cd221c455 100644
> --- a/drivers/mtd/spi-nor/swp.c
> +++ b/drivers/mtd/spi-nor/swp.c
> @@ -62,6 +62,7 @@ static void spi_nor_get_locked_range_sr(struct spi_nor *nor, const u8 *sr, loff_
>  	u8 bp_mask = spi_nor_get_sr_bp_mask(nor);
>  	u8 tb_mask = spi_nor_get_sr_tb_mask(nor);
>  	u8 bp, val = sr[0] & bp_mask;
> +	bool tb = (nor->flags & SNOR_F_HAS_SR_TB) ? sr[0] & tb_mask : 0;
>  
>  	if (nor->flags & SNOR_F_HAS_SR_BP3_BIT6 && val & SR_BP3_BIT6)
>  		val = (val & ~SR_BP3_BIT6) | SR_BP3;
> @@ -81,7 +82,7 @@ static void spi_nor_get_locked_range_sr(struct spi_nor *nor, const u8 *sr, loff_
>  	if (*len > nor->params->size)
>  		*len = nor->params->size;
>  
> -	if (nor->flags & SNOR_F_HAS_SR_TB && sr[0] & tb_mask)
> +	if (tb)
>  		*ofs = 0;
>  	else
>  		*ofs = nor->params->size - *len;
> 




More information about the linux-mtd mailing list