[PATCH] mtd: spi-nor: xmc: Add XM25QH128C identification
Michael Walle
mwalle at kernel.org
Tue Jul 21 01:47:22 PDT 2026
Hi Fabio,
On Mon Jul 20, 2026 at 8:43 PM CEST, Fabio Estevam wrote:
> On Monday, July 20, 2026 03:45 -03, "Michael Walle" <mwalle at kernel.org> wrote:
>
>> So why do you need an entry? We don't add .names on new entries.
>
> Currently, I see:
>
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partname
> spi-nor-generic
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_id
> 204018204018
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer
> cat: /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer: No such file or directory
> root at rk3399-station-p1:~#
>
> After this patch:
>
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partname
> XM25QH128C
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_id
> 204018
> root at rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer
> xmc
>
> The advantage of this patch is to provide the partname and manufacturer entries for userspace.
Yeah I get that, but since vendors tend to reuse their flash ids for
different parts, the part name is useless (and probably wrong) most
of the time. The idea was to just expose the id nowadays and if you
really need the flash part name, it's the duty of an userspace
application to figure that out.
-michael
>
> If this is not wanted, feel free to discard this change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 297 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20260721/db3f4b6a/attachment.sig>
More information about the linux-mtd
mailing list