[PATCH 5/6] jffs2: rename CONFIG_JFFS2_FS_WBUF_VERIFY to CONFIG_JFFS2_FS_WRITE_VERIFY
zhouminqiang
zhouminqiang2 at huawei.com
Thu Aug 20 03:50:01 PDT 2026
Write verification now covers all write paths including NOR direct
writes and write-buffer direct page writes, not just the write-buffer
flush path. The Kconfig option also no longer depends on
CONFIG_JFFS2_FS_WRITEBUFFER.
Rename the option from CONFIG_JFFS2_FS_WBUF_VERIFY to
CONFIG_JFFS2_FS_WRITE_VERIFY to reflect its broader scope and
independence from the write-buffer configuration.
Signed-off-by: zhouminqiang <zhouminqiang2 at huawei.com>
---
fs/jffs2/Kconfig | 23 ++++++++++++++++++-----
fs/jffs2/os-linux.h | 2 +-
fs/jffs2/writev.c | 4 ++--
3 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/fs/jffs2/Kconfig b/fs/jffs2/Kconfig
index 560187d61562..556025a5d438 100644
--- a/fs/jffs2/Kconfig
+++ b/fs/jffs2/Kconfig
@@ -42,13 +42,26 @@ config JFFS2_FS_WRITEBUFFER
- NOR flash with transparent ECC
- DataFlash
-config JFFS2_FS_WBUF_VERIFY
- bool "Verify JFFS2 write-buffer reads"
- depends on JFFS2_FS_WRITEBUFFER
+config JFFS2_FS_WRITE_VERIFY
+ bool "Verify JFFS2 writes"
+ depends on JFFS2_FS
default n
help
- This causes JFFS2 to read back every page written through the
- write-buffer, and check for errors.
+ Read back data immediately after flash writes and compare it
+ with the in-memory image that was written. This covers both
+ write-buffer flushes and direct writes to non-writebuffered
+ devices.
+
+ This may catch corruption introduced after node CRCs are
+ calculated but before/while data is transferred to the flash
+ controller (e.g. RAM or DMA), where mtd_write() may succeed
+ while the medium does not match what JFFS2 intended.
+
+ Without an immediate read-back, a later node CRC failure cannot
+ tell transport/program-time corruption from post-commit media
+ damage.
+
+ If unsure, say 'N'.
config JFFS2_SUMMARY
bool "JFFS2 summary support"
diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h
index e73ef643fd97..65604a6f8148 100644
--- a/fs/jffs2/os-linux.h
+++ b/fs/jffs2/os-linux.h
@@ -192,7 +192,7 @@ int jffs2_flash_direct_writev(struct jffs2_sb_info *c, const struct kvec *vecs,
int jffs2_flash_direct_write(struct jffs2_sb_info *c, loff_t ofs, size_t len,
size_t *retlen, const u_char *buf);
-#ifdef CONFIG_JFFS2_FS_WBUF_VERIFY
+#ifdef CONFIG_JFFS2_FS_WRITE_VERIFY
int jffs2_verify_write(struct jffs2_sb_info *c, const unsigned char *buf,
uint32_t ofs, size_t len);
int jffs2_verify_writev(struct jffs2_sb_info *c,
diff --git a/fs/jffs2/writev.c b/fs/jffs2/writev.c
index 39adc15ffd69..fc1eae60c476 100644
--- a/fs/jffs2/writev.c
+++ b/fs/jffs2/writev.c
@@ -14,7 +14,7 @@
#include <linux/mtd/mtd.h>
#include "nodelist.h"
-#ifdef CONFIG_JFFS2_FS_WBUF_VERIFY
+#ifdef CONFIG_JFFS2_FS_WRITE_VERIFY
int jffs2_verify_write(struct jffs2_sb_info *c, const unsigned char *buf,
uint32_t ofs, size_t len)
{
@@ -98,7 +98,7 @@ int jffs2_verify_writev(struct jffs2_sb_info *c,
}
return 0;
}
-#endif /* CONFIG_JFFS2_FS_WBUF_VERIFY */
+#endif /* CONFIG_JFFS2_FS_WRITE_VERIFY */
int jffs2_flash_direct_writev(struct jffs2_sb_info *c, const struct kvec *vecs,
unsigned long count, loff_t to, size_t *retlen)
--
2.52.0
More information about the linux-mtd
mailing list