[BUG] general protection fault in jffs2_xattr_delete_inode

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Jaeyoung Chung" <jjy600901 at snu.ac.kr>

[...]

> RIP: 0010:jffs2_xattr_delete_inode+0x38/0x300 fs/jffs2/xattr.c:602
> Code: 41 55 41 54 53 48 83 ec 50 48 89 3c 24 48 85 f6 74 2a 49 89 f6 49 bd 00 00
> 00 00 00 fc ff df 48 8d 5e 28 48 89 d8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 0f 85
> 90 02 00 00 83 3b 00 74 14 48 83 c4 50
> RSP: 0018:ffff888104ad7918 EFLAGS: 00010203
> RAX: 0c8c8c8c8c8c8c91 RBX: 646464646464648c RCX: 0000000000000001
> RDX: 0000000000000001 RSI: 6464646464646464 RDI: ffff888108260000
> RBP: dffffc0000000000 R08: ffff888104ad7987 R09: 1ffff1102095af30
> R10: dffffc0000000000 R11: ffffed102095af31 R12: 1ffff11022349cfc
> R13: dffffc0000000000 R14: 6464646464646464 R15: 1ffff11022349ce8
> FS:  00007863627186c0(0000) GS:ffff88815e8ac000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000786362717f78 CR3: 000000010795c000 CR4: 00000000000006f0
> Call Trace:
> <TASK>
> jffs2_do_clear_inode+0x4d/0x2f0 fs/jffs2/readinode.c:1418
> evict+0x353/0x700 fs/inode.c:825
> jffs2_new_inode+0x443/0xce0 fs/jffs2/fs.c:-1
> jffs2_create+0x87/0x300 fs/jffs2/dir.c:182
> lookup_open fs/namei.c:4508 [inline]
> open_last_lookups fs/namei.c:4608 [inline]
> path_openat+0xe3c/0x29b0 fs/namei.c:4860
> do_file_open+0x19d/0x360 fs/namei.c:4892
> do_sys_openat2+0x9a/0x100 fs/open.c:1368
> do_sys_open fs/open.c:1374 [inline]
> __do_sys_openat fs/open.c:1390 [inline]
> __se_sys_openat fs/open.c:1385 [inline]
> __x64_sys_openat+0xf8/0x130 fs/open.c:1385
> do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> do_syscall_64+0xf7/0x370 arch/x86/entry/syscall_64.c:94
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> RIP: 0033:0x78636301e829

So, the partially created inode is evicted in the create path.
Does this change help?

diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h
index 86ab014a349c..a9906f9e3638 100644
--- a/fs/jffs2/os-linux.h
+++ b/fs/jffs2/os-linux.h
@@ -57,6 +57,7 @@ static inline void jffs2_init_inode_info(struct jffs2_inode_info *f)
 	f->target = NULL;
 	f->flags = 0;
 	f->usercompr = 0;
+	f->inocache = NULL;
 }
 
Thanks,
//richard