[PATCH 4/4] mtd: spi-nor: micron-st: enable 8D-8D-8D mode and die erase for mt35xu02gcba

[Bough Chen]

> -----Original Message-----
> From: Tudor Ambarus <tudor.ambarus at linaro.org>
> Sent: 2025年11月10日 14:46
> To: Bough Chen <haibo.chen at nxp.com>; Pratyush Yadav
> <pratyush at kernel.org>; Michael Walle <mwalle at kernel.org>; Miquel Raynal
> <miquel.raynal at bootlin.com>; Richard Weinberger <richard at nod.at>; Vignesh
> Raghavendra <vigneshr at ti.com>
> Cc: linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org;
> imx at lists.linux.dev
> Subject: Re: [PATCH 4/4] mtd: spi-nor: micron-st: enable 8D-8D-8D mode and die
> erase for mt35xu02gcba
> 
> 
> 
> On 11/10/25 6:02 AM, Haibo Chen wrote:
> > mt35xu02gcba is similar with mt35xu01gbba and mt35xu512aba, but with
> > four dies inside. And it also support 8D-8D-8D mode, but SFDP lack
> > SNOR_F_IO_MODE_EN_VOLATILE, so add this fixup flags here.
> >
> > Link:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata
> >
> sheet.octopart.com%2FMT35XU02GCBA1G12-0AAT-Micron-datasheet-138896
> 808.
> >
> pdf&data=05%7C02%7Chaibo.chen%40nxp.com%7Cc6a4b5f4f56f4ca716d208d
> e2024
> >
> d0a0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C6389835396808
> 11304%7
> >
> CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> MCIsIlA
> >
> iOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=6
> Dqhh
> > hlIzdxftTmQzmj%2BcomjZWxWOqpDWP5%2B4NUGCK0%3D&reserved=0
> > Signed-off-by: Haibo Chen <haibo.chen at nxp.com>
> > ---
> 
> please dump the SFDP data for every flash that you touch, it helps us with the
> sfdp database

Hi Tudor,

I do not have this mt35xu02gcba on hand, I only has mt35xu512aba and mt35xu01gbba.
I touch this chip because I notice these three chips share one datasheet, and seems only
has different number of dies.

So should I drop this patch?

Regards
Haibo Chen
> 
> >  drivers/mtd/spi-nor/micron-st.c | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/micron-st.c
> > b/drivers/mtd/spi-nor/micron-st.c index
> >
> f724313f4dd3720908968c670e8d3d58f41c099c..b36174436b7aa0f7768dbe48e
> 4ad
> > 4927c08a3d6d 100644
> > --- a/drivers/mtd/spi-nor/micron-st.c
> > +++ b/drivers/mtd/spi-nor/micron-st.c
> > @@ -214,6 +214,12 @@ static const struct spi_nor_fixups
> mt35xu01gbba_fixups = {
> >  	.late_init = micron_st_nor_two_die_late_init,  };
> >
> > +static const struct spi_nor_fixups mt35xu02gcba_fixups = {
> > +	.default_init = mt35xu512aba_default_init,
> > +	.post_sfdp = mt35xu512aba_post_sfdp_fixup,
> > +	.late_init = micron_st_nor_four_die_late_init, };
> > +
> >  static const struct flash_info micron_nor_parts[] = {
> >  	{
> >  		.id = SNOR_ID(0x2c, 0x5b, 0x1a),
> > @@ -237,12 +243,13 @@ static const struct flash_info micron_nor_parts[] = {
> >  		.fixups = &mt35xu01gbba_fixups,
> >  	}, {
> >  		.id = SNOR_ID(0x2c, 0x5b, 0x1c),
> > -		.name = "mt35xu02g",
> > +		.name = "mt35xu02gcba",
> 
> we don't care about the name, drop the name and add it as a comment.
> 
> >  		.sector_size = SZ_128K,
> >  		.size = SZ_256M,
> >  		.no_sfdp_flags = SECT_4K | SPI_NOR_OCTAL_READ,
> >  		.mfr_flags = USE_FSR,
> > -		.fixup_flags = SPI_NOR_4B_OPCODES,
> > +		.fixup_flags = SPI_NOR_4B_OPCODES |
> SPI_NOR_IO_MODE_EN_VOLATILE,
> 
> Whenever you can, remove the non-sfdp static data and rely on the SFDP driver
> to handle it. Can you please drop sector_size, no_sfdp_flags and
> SPI_NOR_4B_OPCODES?
> 
> Then do the testing and sysfs/debugfs dumps to prove the flash works okay.
> Thanks!
> ta> +		.fixups = &mt35xu02gcba_fixups,
> >  	},
> >  };
> >
> >