[PATCH] mtd: spi-nor: Enable locking for n25q00a

[Tudor Ambarus]

On 11/10/25 6:36 PM, Sean Anderson wrote:
> On 11/10/25 02:08, Tudor Ambarus wrote:
>>
>> The locking tests look fine to me:
>>
>> Acked-by: Tudor Ambarus <tudor.ambarus at linaro.org>
>>
>> Sean, if you care you can extend the documentation on how to test locking.
> 
> I'll take a look.
> 
>> Also, you may drop the non SFDP data from the flash's static definition as
>> a follow up patch.
> 
> I don't understand what you mean by "non SFDP data".
> 

Remove static definitions from the flash entry that can be discovered by SFDP.

For example in your case:

 		.id = SNOR_ID(0x20, 0xbb, 0x21),
 		.name = "n25q00a",
 		.size = SZ_128M,
		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_4BIT_BP |
			 SPI_NOR_BP3_SR_BIT6,
 		.no_sfdp_flags = SECT_4K | SPI_NOR_QUAD_READ,
 		.mfr_flags = USE_FSR,
 		.fixups = &n25q00_fixups,

you can drop size and no_sfdp_flags as this info is discovered when parsing SFDP.

Also, you can drop the name, and add is as a comment.
Cheers,
ta