The locking tests look fine to me: Acked-by: Tudor Ambarus <tudor.ambarus at linaro.org> Sean, if you care you can extend the documentation on how to test locking. Also, you may drop the non SFDP data from the flash's static definition as a follow up patch.