[PATCH 1/3] dt-bindings: spi: Add bindings for SOPHGO SG2042

Krzysztof Kozlowski krzk at kernel.org
Fri May 23 04:33:13 PDT 2025


On 23/05/2025 12:54, Zixian Zeng wrote:
> Add bindings for the SOPHGO SG2042 SPI-NOR flash controller,
> which is compatible with SOPHGO SG2044.
> 
1. This wasn't tested.
2. Breaks existing boards, so you did not test DTS either. Do not
reviewers but machine for such trivialities.

3. A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

4. Please use subject prefixes matching the subsystem. You can get them
for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
directory your patch is touching. For bindings, the preferred subjects
are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof



More information about the linux-mtd mailing list